Originally Posted by Lucky Shot

The higher your hideout, the more effective the spies. The larger town hall you target, the more effective the spies. The fewer spies that the enemy has in their town doing counter espionage, the more effective your spies.

Also, once your spy is in town, let him hang out for a bit for his success percentages to drop.

Lucky Shot